Don't use #[no_mangle] when mocking foreign C functions#603
Open
asomers wants to merge 1 commit into
Open
Conversation
asomers
changed the title
That causes the Rust function to have exactly the same name as the original, so the linker can't link to both. That is, it prevents a program from mocking a C function and still calling the original. This change partially reverts #504. Now, users wishing to call mock functions directly from C must add a one-line wrapper function with the C ABI, as shown in the call-from-c.rs example. Fixes #602
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't use #[no_mangle] when mocking foreign C functions
That causes the Rust function to have exactly the same name as the
original, so the linker can't link to both. That is, it prevents a
program from mocking a C function and still calling the original.
This change partially reverts #504. Now, users wishing to call mock
functions directly from C must add a one-line wrapper function with the
C ABI, as shown in the call-from-c.rs example.
Fixes #602