harden: scope checkout token (persist-credentials: false)#45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
persist-credentials: falseto the credential-persistingactions/checkoutsteps flagged in a workflow-token audit. By defaultactions/checkoutwrites theGITHUB_TOKENinto.git/config, leaving a write-capable credential on disk that any later build/install step can read. These jobs run untrusted build/install code after checkout, so the token was needlessly exposed. GHCR/npm auth here is unaffected (OIDC andGH_TOKENenv), so scoping the checkout token out is a pure hardening.Workflows / jobs fixed:
.github/workflows/release-assets.yml(jobattach) — checkout runs beforenpm pack; the persisted token was readable by that build step..github/workflows/publish.yml(jobpublish) — checkout runs beforenpm ci/npm test; the persisted token was readable by those install/test steps. Publishing is via npm OIDC trusted publishing, not the checkout credential.