Skip to content

Correct TimeoutError inheritance documentation#118

Merged
dblock merged 1 commit into
ashkan18:masterfrom
oiahoon:docs/correct-timeout-error-inheritance
Jul 16, 2026
Merged

Correct TimeoutError inheritance documentation#118
dblock merged 1 commit into
ashkan18:masterfrom
oiahoon:docs/correct-timeout-error-inheritance

Conversation

@oiahoon

@oiahoon oiahoon commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • correct the documented TimeoutError inheritance and rescue guidance
  • explain that Faraday client timeouts have no server response or status code
  • add the required next-release changelog entry

Testing

  • bundle exec rake (56 RuboCop files, 96 RSpec examples)
  • source/documentation inheritance consistency check
  • git diff --check origin/master...HEAD

Fixes #92

@oiahoon
oiahoon force-pushed the docs/correct-timeout-error-inheritance branch from 38609e1 to b90a96e Compare July 14, 2026 16:48
@github-actions

Copy link
Copy Markdown

Danger Report

No issues found.

View run

@dblock

dblock commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Thanks for this.

@dblock
dblock merged commit 451c1f5 into ashkan18:master Jul 16, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs incorrectly state that Graphlient::Errors::TimeoutError does not inherit from Graphlient::Errors::ServerError

2 participants