Skip to content

Fix warning about version >= 3.41.0 requirement #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mkly wants to merge 1 commit into from
Closed

Fix warning about version >= 3.41.0 requirement #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/extension.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,7 +813,7 @@ static int vssIndexFilter(
// https://sqlite.org/forum/info/6b32f818ba1d97ef
else if(sqlite3_libversion_number() < 3041000) {
sqlite3_free(pVtabCursor->pVtab->zErrMsg);
pVtabCursor->pVtab->zErrMsg = sqlite3_mprintf("vss_search() only support vss_search_params() as a 2nd parameter for SQLite versions below 3.41.0");
pVtabCursor->pVtab->zErrMsg = sqlite3_mprintf("vss_search() only support vss_search_params() as a 2nd parameter for SQLite versions at or above 3.41.0");
Copy link
Copy Markdown

@ankon ankon Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're there anyways:

Suggested change
pVtabCursor->pVtab->zErrMsg = sqlite3_mprintf("vss_search() only support vss_search_params() as a 2nd parameter for SQLite versions at or above 3.41.0");
pVtabCursor->pVtab->zErrMsg = sqlite3_mprintf("vss_search() only supports vss_search_params() as a 2nd parameter for SQLite versions at or above 3.41.0");

Copy link
Copy Markdown
Author

@mkly mkly Jul 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look. Both changes are updated in a new PR to make things cleaner to review. See #72

return SQLITE_ERROR;
}
else if ((query_vector = pCur->table->vector_api->xValueAsVector(argv[0])) != NULL) {
Expand Down Expand Up @@ -1293,4 +1293,4 @@ extern "C" {
}
}

#pragma endregion
#pragma endregion