fix: fix scene detail toolbar overflowing viewport on firefox#2660
Draft
lllarsen wants to merge 13 commits into
Draft
fix: fix scene detail toolbar overflowing viewport on firefox#2660lllarsen wants to merge 13 commits into
lllarsen wants to merge 13 commits into
Conversation
lllarsen
commented
Jun 23, 2026
| [style.height.px]="menuHeightPx" | ||
| mwlResizable | ||
| [validateResize]="validate" | ||
| [enableGhostResize]="true" |
Contributor
Author
There was a problem hiding this comment.
this is necessary as the ghost resize element is position: fixed. There is an option to make it position: absolute but I could not get it to work.
lllarsen
commented
Jun 23, 2026
…ace for the toolbar to reside
lllarsen
force-pushed
the
lily/stylinginconsistency
branch
from
01fc065 to
d9e145e
Compare
lllarsen
force-pushed
the
lily/stylinginconsistency
branch
from
d9e145e to
62b9b46
Compare
lllarsen
force-pushed
the
lily/stylinginconsistency
branch
from
62b9b46 to
f25d982
Compare
Contributor
Author
|
/update-snapshots |
1 similar comment
Contributor
Author
|
/update-snapshots |
lllarsen
force-pushed
the
lily/stylinginconsistency
branch
from
9bdf9ed to
28e982d
Compare
…l does not scroll
Contributor
Author
|
/update-snapshots |
lllarsen
force-pushed
the
lily/stylinginconsistency
branch
from
18e38e6 to
96fdffc
Compare
Contributor
Author
|
/update-snapshots |
lllarsen
force-pushed
the
lily/stylinginconsistency
branch
from
10fbc19 to
eba2e37
Compare
Contributor
Author
|
/update-snapshots |
lllarsen
force-pushed
the
lily/stylinginconsistency
branch
from
5a77378 to
2f523d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the scene detail toolbar overflowing the viewport on firefox by positioning the results menu using css grid layout instead of a
position: fixedwhich breaksposition: stickyin firefox.Related Issues
TOOL-4845
i18n
Tests & Build
npm run lintpassesnpm testpasses (or N/A)npm run buildsucceedsNotes
To prevent z-indexing issues the results menu is positioned using
position: relative. This is a hacky fix which I will address before finishing this pr. Another note is that I hope to removeposition: stickyfrom the toolbar and utilize css grid to position it as well.