Skip to content

Add validation of deploy_name in env.sh#256

Merged
ygliuvt merged 1 commit into
cumulus-infrafrom
cumulus-4953-1
Jun 15, 2026
Merged

Add validation of deploy_name in env.sh#256
ygliuvt merged 1 commit into
cumulus-infrafrom
cumulus-4953-1

Conversation

@ygliuvt

@ygliuvt ygliuvt commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

There is a note on the Consolidated Cumulus deployment wiki:

Prefix Choice
During initial deployment, we ran into an error due to the maximum length of a resource name, 
so you will want to keep this prefix relatively short if choosing something other than this convention. 

We should add the prefix check in the script itself so that people don't run into the error far into the deployment only to find out that their prefix choice is too long and it takes hours to rewind the deployment and try again.

Add validation of deploy_name in env.sh so that we can avoid time consuming deployment errors later.

@Jkovarik Jkovarik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic 💯

@ygliuvt ygliuvt merged commit c4beafb into cumulus-infra Jun 15, 2026
1 check passed
@ygliuvt ygliuvt deleted the cumulus-4953-1 branch June 15, 2026 13:27
@Jkovarik

Copy link
Copy Markdown
Collaborator

@ygliuvt I was forced to revert this as there are stacks that violate the constraint that are not depoying iceberg. We will want to re-merge the change once those stacks are no longer in use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants