Add validation of deploy_name in env.sh#256
Merged
Merged
Conversation
Collaborator
|
@ygliuvt I was forced to revert this as there are stacks that violate the constraint that are not depoying iceberg. We will want to re-merge the change once those stacks are no longer in use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a note on the Consolidated Cumulus deployment wiki:
We should add the prefix check in the script itself so that people don't run into the error far into the deployment only to find out that their prefix choice is too long and it takes hours to rewind the deployment and try again.
Add validation of deploy_name in env.sh so that we can avoid time consuming deployment errors later.