fix: bug with asdf_ndarray_data_alloc_temp that leaked/orphaned existing internal data#189
Merged
Merged
Conversation
…ing internal data Found specifically in the case of calling `asdf_ndarray_storage_set(...)` followed by `asdf_ndarray_data_alloc_temp` but could in principle be triggered in other ways. Solution is to simply use the `asdf_ndarray_internal(...)` helper which is intended for this, not directly allocating a new `asdf_ndarray_internal_t`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found specifically in the case of calling
asdf_ndarray_storage_set(...)followed byasdf_ndarray_data_alloc_tempbut could in principle be triggered in other ways. Solution is to simply use theasdf_ndarray_internal(...)helper which is intended for this, not directly allocating a newasdf_ndarray_internal_t.