feat(vscode): restore the extension source from rac-core [roadmap:rac-editors-buildout]#3
Merged
Merged
Conversation
…-editors-buildout] Recovered from asdecided/core@168a02f (typescript/rac-vscode/, the last tree before the v0.22.5 removal, eed463e^). Full per-file history remains permanently reachable in rac-core; this snapshot records the provenance rather than replaying engine-scoped history onto the family trunk. Deviations from the recovered tree, both finishing recorded contracts: - @itsthelore/rac-sdk resolves from npm (^0.1.0) instead of file:../rac-sdk, completing the v0.22.5 repoint the removed tree never received; the lockfile is regenerated against the registry. - The stale MIT LICENSE is not restored: the family repo's Apache-2.0 LICENSE stands (ADR-071; the recovered package.json already declares Apache-2.0). out/ joins the ignore list.
…ldout] pr-checks.yml runs the recovered v0.21.9 gate per ADR-027/ADR-075: install, typecheck, bundle, @vscode/test-electron integration tests under xvfb with a PyPI-installed rac, and a VSIX packaging smoke with the artifact uploaded. Adapted from rac-core's typescript.yml and extension-release.yml gate steps.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements initiative 1 (and the battery half of initiative 2) of
rac/roadmaps/rac-editors-buildout.md(rac-core; the roadmap-intent PR is queued behind asdecided/core#250 and lands next).Adds:
vscode/— recovered fromitsthelore/rac-core@168a02f(typescript/rac-vscode/, the last tree before the v0.22.5 removaleed463e), as a snapshot with provenance in the commit body rather than a replay of engine-scoped history onto the family trunk.file:../rac-sdkto the published@itsthelore/rac-sdk@^0.1.0with a lockfile regenerated against the registry — completing the v0.22.5 repoint contract the removed tree never received..github/workflows/pr-checks.yml: the vscode merge-gate battery (ADR-027/ADR-075) — install, typecheck, bundle,@vscode/test-electronintegration tests under xvfb with a PyPI-installedrac, VSIX packaging smoke, artifact upload.Roadmap / ADR Trace
Roadmap:
rac/roadmaps/rac-editors-buildout.md(rac-core)rac/roadmaps/v0.21.x-editor/v0.21.9-extension-test-harness.md— the gate this battery runsRelevant ADRs (rac-core corpus):
racCLI, never engine internalsmainScope
Included
@vscode/test-electronVS Code download locally; CI is where the integration tests run).out/added tovscode/.gitignore(test-compile output; previously covered by rac-core's root ignore).Excluded
package.jsonstill carries the recovered pre-ADR-092 identity (publisher: "rac", "RAC — Requirements as Code"). The listing identity is a fenced human decision (deferred pending a possible brand re-decision) and blocks only the first publish.LICENSEin the recovered tree is deliberately not restored — the family repo's Apache-2.0 LICENSE stands (ADR-071; the recoveredpackage.jsonalready declares Apache-2.0).Product / Architecture Decisions
168a02f) is a durable pointer into rac-core where the full per-file history lives.racfrom PyPI (rac-core) rather than from source — rac-editors consumes the public contract only (ADR-063).User-Facing Contract
No published-surface change: the extension is still unpublished (v0.21.10). The extension's behavior is unchanged from the recovered tree; only the SDK resolution and repository home moved.
Verification
Ran (locally)
npm install—@itsthelore/rac-sdk@0.1.0resolves from the registry; zerofile:references in the lockfilenpm run check-types— clean against the published SDK (API surface compatible)npm run compile+npm run compile-tests— bundle and test compile cleannpx vsce package— VSIX builds: 11 files, 39.77 KB, manifest sane (bundleddist/extension.js, nonode_modules)Not runnable locally, proven by this PR's CI
xvfb-run npm test— the@vscode/test-electrondownload is blocked by this environment's network policy; thepr-checksrun on this PR is the verification.Review Path
vscode/package.json(dependency repoint, recovered identity untouched).github/workflows/pr-checks.ymlvscode/src/(recovered verbatim from168a02f— diffable against rac-core)Notes For Reviewer
git diff 168a02f:typescript/rac-vscode vscode/in rac-core shows exactly three intentional deltas — the SDK dependency line, the regenerated lockfile, and.gitignore(+out/), plus the absent MIT LICENSE.pr-checksonmainis an org action (ADR-075) — tracked in Epic: rac-editors build-out — recover the extension, gate it, publish it #2.Implementation Process
Implemented with AI assistance under the roadmap contract; final scope, review, and acceptance decisions were made by the maintainer.