feat(providers): stream direct GPT-5.6 replies on iOS#123
Open
tcballard wants to merge 3 commits into
Open
Conversation
tcballard
marked this pull request as ready for review
July 25, 2026 16:32
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the generic direct-provider slice of
WF-ROADMAP-0016.Adds:
Scope
Included
gpt-5.6aliasURLSessionstreaming from iOS with a 60-second request timeoutExcluded
Product / Architecture Decisions
ProviderExecutor; SwiftUI does not read Keychain or perform network work.KeychainCredentialStorefor readiness and execution while exposing only configured/not-configured snapshots toAppModel.gpt-5.6alias after verifying official OpenAI guidance and Chat Completions support.User-Facing Contract
Chat
Automatic — Wayfinder choosesandGPT-5.6.Destinations
ReadyorKey required.Network Contract
POST https://api.openai.com/v1/chat/completionsmodel: "gpt-5.6"[DONE]Failure Contract
Verification
Ran
xcodegen generate --spec ios/WayfinderIOS/project.ymlxcrun swift-format format --in-placeover every changed Swift source and testtest_simon iPhone 17, iOS 26.3, signed Debug buildtest_simwithCODE_SIGNING_ALLOWED=NOto match Apple mobile CIbuild_run_simand runtime accessibility snapshot of the destination menugit diff --checkCovered
Review Path
OpenAICompatibleProvider.swift— credential custody, request bounds, streaming, cancellation, and error normalizationChatExecution.swiftandAppModel.swift— typed history and explicit pinned-route orchestrationWayfinderIOSApp.swift,ChatTabView.swift, andDestinationsView.swift— production dependency graph and minimal controlsOpenAICompatibleProviderTests.swiftandAppModelTests.swift— protocol and product-boundary evidenceNotes For Reviewer
Implementation Process
Implemented with AI assistance under the roadmap contract; final scope, review, and acceptance decisions remain with the maintainer.