feat(ios): complete deterministic Chat lifecycle#121
Merged
Conversation
tcballard
marked this pull request as ready for review
July 24, 2026 14:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the final Phase 2 Chat lifecycle in
WF-ROADMAP-0016.Adds:
Scope
Included
Excluded
Product / Architecture Decisions
ProviderExecutorcontract and emits ordered deltas plus one terminal completion event.AppModelowns one active request identifier and rejects concurrent sends, thread changes, and new-chat actions while generation is active.TabViewwas removed because iOS 26 rendered it as an empty glass capsule.User-Facing Contract
CLI
No CLI changes.
Human Output
JSON Output
No public JSON schema changes. Conversation exports may now contain the
streamingmessage-status value while an in-progress state is persisted.Exit Codes
No exit-code changes.
Verification
Ran
Result: 22 tests passed, 0 failed, with no build warnings.
Also built, installed, launched, and exercised the app on an iPhone 17 simulator. Verified:
Covered
Review Path
ChatExecution.swiftfor the bounded provider and event contract.AppModel.swiftfor routing, execution transitions, persistence, stop, and retry.ChatTabView.swiftandRootView.swiftfor transcript/composer and compact navigation behavior.AppModelTests.swiftandConversationStoreTests.swiftfor lifecycle evidence.Notes For Reviewer
The response is intentionally deterministic and network-free. Phase 3 owns Keychain and the first live OpenAI-compatible provider; this PR does not anticipate or broaden those credential boundaries.