Skip to content

Fixed box construction error by excluding array_impl type #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aimoonchen wants to merge 1 commit into from
Closed

Fixed box construction error by excluding array_impl type #316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion immer/box.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,34 @@
#include <immer/memory_policy.hpp>

#include <cstddef>
#include <type_traits>

namespace immer {

namespace detail {
namespace arrays {
// Forward declarations for SFINAE
template <typename T, typename MemoryPolicy>
struct with_capacity;
template <typename T, typename MemoryPolicy>
struct no_capacity;
} // namespace arrays

// Type trait to detect internal array implementation types
template <typename T>
struct is_array_impl : std::false_type {};

template <typename T, typename MP>
struct is_array_impl<arrays::with_capacity<T, MP>> : std::true_type {};

template <typename T, typename MP>
struct is_array_impl<arrays::no_capacity<T, MP>> : std::true_type {};

template <typename T>
inline constexpr bool is_array_impl_v = is_array_impl<std::decay_t<T>>::value;

} // namespace detail

namespace detail {

template <typename U, typename MP>
Expand Down Expand Up @@ -77,7 +102,8 @@ class box
*/
template <typename Arg,
typename Enable = std::enable_if_t<
!std::is_same<box, std::decay_t<Arg>>::value>>
!std::is_same<box, std::decay_t<Arg>>::value &&
!detail::is_array_impl_v<Arg>>>
box(Arg&& arg)
: impl_{detail::make<heap, holder>(std::forward<Arg>(arg))}
{
Expand Down