fix: add output encoding in reformator.js - #2
Open
anupamme wants to merge 1 commit into
Open
Conversation
The WYSIWYG editor's make() method writes unsanitized HTML content directly into an iframe document using document
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
reformator.js.Vulnerability
V-001reformator.js:630Description: The WYSIWYG editor's make() method writes unsanitized HTML content directly into an iframe document using document.write(). The preprocess() function performs no XSS sanitization, allowing attacker-controlled HTML/JavaScript to execute in the page context.
Evidence
Exploitation scenario: Attacker stores malicious HTML in a CMS field rendered into a reformator-managed textarea:
.
Scanner confirmation: multi_agent_ai rule
V-001flagged this pattern.Production code: This file is in the production codebase, not test-only code.
Changes
reformator.jsBehavior Preservation
The change is scoped to 1 file on the vulnerable path; it only tightens handling of untrusted input and leaves valid inputs unaffected.
Automated security fix by OrbisAI Security