Fix method check for partialmethod attribute#46
Open
xsro wants to merge 1 commit into
Open
Conversation
Member
|
Hi, thank you for the PR but unfortunately this project is right now unmaintained (I believe). That being said, I think we could still merge your PR. I did some test myself on Python 3.12 and it seems like |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for maintaining such a great project!
I tested this library with the Bolts robot and encountered a small compatibility issue related to Python's
partialmethodimplementation.As Python 3.10 renamed the internal
_partialmethod(single underscore) to__partialmethod__(double underscores) for stronger encapsulation of itsfunctools.partialmethodunderpinning, this causes compatibility gaps across different Python versions.This patch addresses the issue by properly checking the parent of
partialmethodto support both the old and new internal identifiers, ensuring broader Python version compatibility.Would you consider merging this fix?