Checkpoint in log checking improvement; extraction of compile aliases…#408
Open
rrivera747 wants to merge 5 commits into
Open
Checkpoint in log checking improvement; extraction of compile aliases…#408rrivera747 wants to merge 5 commits into
rrivera747 wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the tools/ots log-finding capabilities with new modes for local-only and ARTDAQ-host log discovery, and factors compile-related shell aliases into a standalone script installed via the tools CMake packaging.
Changes:
- Added
ots -ll/--logfind-local(local-only) andots -lll/--logfind-artdaq(local + ARTDAQ hosts from latestranks.txt) log-finding modes. - Implemented expanded “recently written files” scanning under
$USER_DATA/Logs, action-handler logs undertmp/, and ARTDAQ configuration/run-record locations. - Added and installed
tools/ots_compile_aliases.shas a reusable compile-alias helper script.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| tools/ots_compile_aliases.sh | New compile alias helper with lockfile protection and build/install logging. |
| tools/ots | Adds new logfind flags and substantial log discovery + remote SSH parsing logic. |
| tools/CMakeLists.txt | Installs the new ots_compile_aliases.sh script via cet_script(ALWAYS_COPY ...). |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
need to revisit the review of this branch.. because moved onto rrivera/fixConfigDumpSend which will have merge conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… as general tool