Skip to content

fix: topo install command needs to include target#265

Open
federicobozzini wants to merge 2 commits into
mainfrom
install-command-target
Open

fix: topo install command needs to include target#265
federicobozzini wants to merge 2 commits into
mainfrom
install-command-target

Conversation

@federicobozzini
Copy link
Copy Markdown
Contributor

@federicobozzini federicobozzini commented May 8, 2026

Changes

  • added --target flag to the topo install fix command

###Before

$ topo health --target xxx
Host
----
Topo: ✅ (topo)
SSH: ✅ (ssh)
Curl: ✅ (curl)
Container Engine: ✅ (docker)

Target
------
Destination: ssh://xxx
Connectivity: ✅
Container Engine: ✅ (docker)
Remoteproc Runtime: ⚠️ ("remoteproc-runtime" not found on remote target's $PATH)
  Fix: Install the remoteproc runtime
  Cmd: topo install remoteproc-runtime
Remoteproc Shim: ⚠️ ("containerd-shim-remoteproc-v1" not found on remote target's $PATH)
  Fix: Install the remoteproc runtime
  Cmd: topo install remoteproc-runtime
Hardware Info: ✅ (lscpu)
Subsystem Driver (remoteproc): ✅ (imx-rproc)

###After:

$ topo health --target xxx
Host
----
Topo: ✅ (topo)
SSH: ✅ (ssh)
Curl: ✅ (curl)
Container Engine: ✅ (docker)

Target
------
Destination: ssh://xxx
Connectivity: ✅
Container Engine: ✅ (docker)
Remoteproc Runtime: ⚠️ ("remoteproc-runtime" not found on remote target's $PATH)
  Fix: Install the remoteproc runtime
  Cmd: topo install remoteproc-runtime --target ssh://xxx
Remoteproc Shim: ⚠️ ("containerd-shim-remoteproc-v1" not found on remote target's $PATH)
  Fix: Install the remoteproc runtime
  Cmd: topo install remoteproc-runtime --target ssh://xxx
Hardware Info: ✅ (lscpu)
Subsystem Driver (remoteproc): ✅ (imx-rproc)

Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
@federicobozzini federicobozzini requested a review from a team as a code owner May 8, 2026 15:33
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
deps := health.TargetRequiredDependencies(ssh.NewDestination("user@my-target"))

var got string
for _, dep := range deps {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's almost as if this test was screaming at us: don't do it this way.

I have some reservations about making TargetDependencies a function for the sake of making a single fix contain the --target. I'm not sure if this is the best way to model this. Did you explore any other way to do this? 🤔

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another idea I had was to change generateDependencyReport but the result is awful. I definitely prefer this approach. I think it allows decently with how connectivityCheck works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants