fix: topo install command needs to include target#265
Open
federicobozzini wants to merge 2 commits into
Open
Conversation
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
muchzill4
reviewed
May 11, 2026
| deps := health.TargetRequiredDependencies(ssh.NewDestination("user@my-target")) | ||
|
|
||
| var got string | ||
| for _, dep := range deps { |
Contributor
There was a problem hiding this comment.
It's almost as if this test was screaming at us: don't do it this way.
I have some reservations about making TargetDependencies a function for the sake of making a single fix contain the --target. I'm not sure if this is the best way to model this. Did you explore any other way to do this? 🤔
Contributor
Author
There was a problem hiding this comment.
Another idea I had was to change generateDependencyReport but the result is awful. I definitely prefer this approach. I think it allows decently with how connectivityCheck works.
Luke-Parkin
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
--targetflag to thetopo installfix command###Before
###After: