Skip to content

feat: add destination to health output#262

Merged
awphi merged 11 commits into
mainfrom
destination-in-health
May 8, 2026
Merged

feat: add destination to health output#262
awphi merged 11 commits into
mainfrom
destination-in-health

Conversation

@awphi
Copy link
Copy Markdown
Contributor

@awphi awphi commented May 7, 2026

Changes

  • Short n sweet; adds Destination (plain) and destination (json) to topo health output:
...

Target
------
Destination: ssh://root@xyz:4040
...

Thought about putting next to "Target" as the section header but felt weird + we need to start measuring how long to make the hyphen border beneath so went with the easiest possible change for now. JSON output is hopefully uncontentious.

Signed-off-by: awphi <26072111+awphi@users.noreply.github.com>
@awphi awphi requested a review from a team as a code owner May 7, 2026 13:39
Comment thread internal/health/health_test.go Outdated
Signed-off-by: awphi <26072111+awphi@users.noreply.github.com>
@awphi awphi marked this pull request as draft May 7, 2026 14:35
@awphi awphi marked this pull request as draft May 7, 2026 14:35
@awphi awphi marked this pull request as ready for review May 7, 2026 15:22
@awphi awphi force-pushed the destination-in-health branch from d166a96 to 296074b Compare May 7, 2026 15:23
Comment thread e2e/health_test.go Outdated
awphi added 8 commits May 8, 2026 09:28
Signed-off-by: awphi <26072111+awphi@users.noreply.github.com>
Signed-off-by: awphi <26072111+awphi@users.noreply.github.com>
Signed-off-by: awphi <26072111+awphi@users.noreply.github.com>
This reverts commit ea1f89d.
Signed-off-by: awphi <26072111+awphi@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@muchzill4 muchzill4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@awphi awphi merged commit 28f58e7 into main May 8, 2026
5 checks passed
@awphi awphi deleted the destination-in-health branch May 8, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants