feat!: add explicit command to fix target health issues#261
Conversation
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
muchzill4
left a comment
There was a problem hiding this comment.
There's a lot of duplication between Fix and FixCommand, can you think of a way where we could use FixCommand as the source of truth for the command, and Fix only for the meta text?
Something like (pseudo-template):
{{Issue}}
{{Fix}}
{{If FixCommand}}
-> run `{{FixCommand}}`
This was also my first thought but:
I think this is one of those cases where removing dupilications makes things messier rather than cleaner. |
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
muchzill4
left a comment
There was a problem hiding this comment.
Thanks for introducing the nilable Fix and tweaking descriptions all over the shop. This is going to be much better than what we had. 🦾
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
Changes
fixCommandproperty to the output result of the health check. This property doesn't appear in plain output, only json.