Skip to content

refactor: manually calculate image names instead of using docker compose#259

Merged
muchzill4 merged 4 commits into
arm:mainfrom
muchzill4:refactor/image-names
May 8, 2026
Merged

refactor: manually calculate image names instead of using docker compose#259
muchzill4 merged 4 commits into
arm:mainfrom
muchzill4:refactor/image-names

Conversation

@muchzill4
Copy link
Copy Markdown
Contributor

Changes

  • Calculate image names using data from compose file instead of relying on docker compose config --images
    • Enables support for container engines that follow different image name semantics

@muchzill4 muchzill4 requested a review from a team as a code owner May 7, 2026 08:12
@muchzill4 muchzill4 force-pushed the refactor/image-names branch from 6c0db57 to 2f49acc Compare May 7, 2026 13:07
Comment thread internal/compose/compose_test.go
@muchzill4 muchzill4 force-pushed the refactor/image-names branch from cf1b992 to 4ccc911 Compare May 8, 2026 08:42
@muchzill4 muchzill4 requested a review from awphi May 8, 2026 14:16
Copy link
Copy Markdown
Contributor

@awphi awphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry have been context switching way too much and completely forgot I promised to re-review. LGTM!

Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
@muchzill4 muchzill4 force-pushed the refactor/image-names branch from 4ccc911 to d3a7fb7 Compare May 8, 2026 14:21
@muchzill4 muchzill4 merged commit 73f6529 into arm:main May 8, 2026
5 checks passed
@muchzill4 muchzill4 deleted the refactor/image-names branch May 8, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants