Use the ARM for check_std - #4
Open
weikengchen wants to merge 1 commit into
Open
Conversation
Pratyush
reviewed
Nov 17, 2020
Comment on lines
+110
to
+113
| - name: Check | ||
| run: | | ||
| cargo build --no-default-features --target aarch64-unknown-none | ||
| cargo check --examples --no-default-features --target aarch64-unknown-none |
Member
There was a problem hiding this comment.
Why not use the other structure, while changing the target to aarch64-unknown-none?
Pratyush
reviewed
Nov 17, 2020
| with: | ||
| command: check | ||
| args: --all-features --examples --workspace --benches | ||
| args: --all-features --examples --all --benches |
Pratyush
reviewed
Nov 17, 2020
| args: "--workspace \ | ||
| --all-features \ | ||
| --exclude ark-poly-benches" | ||
| args: "--all \ |
Member
There was a problem hiding this comment.
Suggested change
| args: "--all \ | |
| args: "--workspace \ |
Pratyush
reviewed
Nov 17, 2020
| runs-on: ubuntu-latest | ||
| env: | ||
| RUSTFLAGS: -Dwarnings | ||
| RUSTFLAGS: -Dwarnings --cfg ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding the CI for PCD and IVLS, I revisit this document.
I made some changes based on the CI.yml of
nonnativebut I am not sure if they are appropriate for the template.Thoughts?