Harden portable boundary checks#87
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d67ac6951c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [regex]::Matches($skillsMatch.Groups[1].Value, '"([^"]+)"') | | ||
| ForEach-Object { $_.Groups[1].Value } |
There was a problem hiding this comment.
If a maintainer comments out or annotates an entry inside [agents].skills, for example # "old-skill", or an inline note containing a quoted skill name, this regex still captures the quoted text as an active skill even though TOML would ignore it. That makes install, snapshot, and retired-copy maps continue acting on commented-out skills, and the doctor check uses the same style of extraction so it would not catch the mismatch.
Useful? React with 👍 / 👎.
1 participant
Portable setup should fail closed when the manifest, install map, or live retired copies drift apart. Validated with .\scripts\doctor.ps1, git diff --check, install and snapshot review modes, and temp-home missing-source and retired-copy checks.