Skip to content

Added salvage table to items details - #385

Open
fresnizky wants to merge 2 commits into
arenanet:masterfrom
fresnizky:add-salvage-data
Open

Added salvage table to items details#385
fresnizky wants to merge 2 commits into
arenanet:masterfrom
fresnizky:add-salvage-data

Conversation

@fresnizky

Copy link
Copy Markdown

Add salvage table for salvagable items, listing all possible salvages with min values (using crude salvage kit), and max values (using master salvage kit)

@ChieftainAlex

Copy link
Copy Markdown

this sounds like a ridiculous amount of content to fit into an api query.

@fresnizky

Copy link
Copy Markdown
Author

That's a good point. It could be made available only when you query for a single item

@tivac

tivac commented Oct 25, 2016

Copy link
Copy Markdown
Contributor

Our system doesn't tend to differentiate between a single item and 200 items, it all looks the same in code. Changing the response based on # of items requested seems like a surprising choice and surprises are real bad in any API you want to consume.

I think it would need to be broken out into a /v2/salvage style endpoint where you could cross-reference. Otherwise it's just way too much data coming back.

@fresnizky

Copy link
Copy Markdown
Author

I'll update my PR to a new endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants