Added salvage table to items details - #385
Open
fresnizky wants to merge 2 commits into
Open
Conversation
|
this sounds like a ridiculous amount of content to fit into an api query. |
Author
|
That's a good point. It could be made available only when you query for a single item |
Contributor
|
Our system doesn't tend to differentiate between a single item and 200 items, it all looks the same in code. Changing the response based on # of items requested seems like a surprising choice and surprises are real bad in any API you want to consume. I think it would need to be broken out into a |
Author
|
I'll update my PR to a new endpoint |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add salvage table for salvagable items, listing all possible salvages with min values (using crude salvage kit), and max values (using master salvage kit)