Skip to content

Flowc check unique import resolving#1107

Open
dmitry-vlasov wants to merge 9 commits into
masterfrom
flowc_check_unique_import_resolving
Open

Flowc check unique import resolving#1107
dmitry-vlasov wants to merge 9 commits into
masterfrom
flowc_check_unique_import_resolving

Conversation

@dmitry-vlasov

Copy link
Copy Markdown
Contributor

No description provided.

@alstrup alstrup left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are performance consequences for this? We do not want to scan all folders to check this, since that would too slow, especially on Windows.

@Eugeny48 Eugeny48 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but sometimes applications have the same local file to import that has a higher priority then the file from the innovation repo. So it is worth checking that the improvement will not harm our applications.

@dmitry-vlasov

Copy link
Copy Markdown
Contributor Author

What are performance consequences for this? We do not want to scan all folders to check this, since that would too slow, especially on Windows.

The performance must be almost the same, unless a huge 'include' arrays of paths are in flow.config. The difference is: previous version scanned 'include' array until a first existent file is met, this PR scans all 'include' array to the end, finding all variants of existent combinations inclde + flowfile.

@dmitry-vlasov

Copy link
Copy Markdown
Contributor Author

It looks good, but sometimes applications have the same local file to import that has a higher priority then the file from the innovation repo. So it is worth checking that the improvement will not harm our applications.

For this case it's reasonable to make this check off by default, and turn it on explicitly with a compiler option

@shkel

shkel commented Dec 8, 2022

Copy link
Copy Markdown
Contributor

I can't reproduce the bug :( Maybe it is related to the issue we have to clean up objc. But I don't have objections to PR

@alstrup

alstrup commented Dec 10, 2022

Copy link
Copy Markdown
Contributor

I am not comfortable with scanning all include folders for each file. That will probably be a slowdown, especially on Windows. We are compiling thousands and thousands of files, and checking file existance is super slow. Please check, or hide behind flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants