fix(frontend): pass empty query to reinit mutation; add typecheck script#56
Open
tobias-gp wants to merge 1 commit into
Open
fix(frontend): pass empty query to reinit mutation; add typecheck script#56tobias-gp wants to merge 1 commit into
tobias-gp wants to merge 1 commit into
Conversation
The connections reinit route uses zValidator("query", ...) with an
optional `reset` flag. The Hono client's inferred type makes the
`query` argument required even when all fields are optional, so the
call site was a TypeScript error.
CI never caught this because the frontend lacked a `typecheck` script
(so `pnpm typecheck` skipped it) and the Docker build runs
`vite build` directly, which doesn't type-check. Add the missing
script so future regressions surface in the Lint & Typecheck job.
Co-authored-by: Cursor <cursoragent@cursor.com>
|
🚅 Deployed to the archmax-pr-56 environment in archmax SemLayer
|
Docker image readydocker pull ghcr.io/archmaxai/archmax:pr-56 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
query: {}when calling thereinitmutation. The route useszValidator("query", reinitQuerySchema)with an optionalresetflag, so Hono's RPC client makes thequeryargument required (even though every field is optional). The call site was a real TypeScript error onmain.typecheckscript (tsc --noEmit) to@archmax/frontend. Without it,pnpm typecheck(and the CI Lint & Typecheck job) silently skipped this package, and the Docker build runsvite builddirectly (notsc), which is how the error reachedmainunnoticed.Test plan
pnpm typecheck— now runs across 8 packages (was 7) and passespnpm build— full workspace build succeeds, includingtsc && vite buildfor frontendMade with Cursor