Skip to content

Clean-up modcc output#2496

Open
thorstenhater wants to merge 17 commits intoarbor-sim:masterfrom
thorstenhater:perf/symge
Open

Clean-up modcc output#2496
thorstenhater wants to merge 17 commits intoarbor-sim:masterfrom
thorstenhater:perf/symge

Conversation

@thorstenhater
Copy link
Copy Markdown
Contributor

@thorstenhater thorstenhater commented Mar 2, 2026

  1. add a series of algebraic simplifications to NMODL output
  • -(-a) == a contraction
  • -(a - b) == b - a
  • ...
  1. add detection and emission of fused-mul-add operations
  2. handle all SIMD constraint from Arbor in NMODL
  3. replace more << output with fmt for cleaner reading

These can yield faster code, but doesn't in my local benchmarking, likely because the
C++ compiler is smart enough to spot these. However, it makes the output cleaner and
might help the odd compiler.

Comment thread modcc/symdiff.cpp Outdated

}
else if (expr_value(rhs)==-1) {
else if (expr_value(lhs) == -1.0) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is rhs no?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES!

@thorstenhater thorstenhater requested a review from ibanezbm April 15, 2026 07:14
Copy link
Copy Markdown
Collaborator

@ibanezbm ibanezbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants