Skip to content

chore: bump to pyo3 0.29#199

Open
cimandef wants to merge 2 commits into
mainfrom
angel/upgrade_py03
Open

chore: bump to pyo3 0.29#199
cimandef wants to merge 2 commits into
mainfrom
angel/upgrade_py03

Conversation

@cimandef

@cimandef cimandef commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

depends on: PyO3/pyo3-async-runtimes#85

Summary by CodeRabbit

  • Chores
    • Updated Python bindings dependencies to newer versions across project configuration files (including the async runtime integration)
  • Refactor
    • Simplified Python version retrieval to use a static version string rather than attaching to the Python interpreter
    • Updated both version reporting and CLI telemetry context setup to rely on the streamlined version information flow

@cimandef cimandef self-assigned this Jun 12, 2026
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8ff6ad17-8769-4761-9f6b-e53436d303fa

📥 Commits

Reviewing files that changed from the base of the PR and between cf55583 and a7044ae.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • Cargo.toml
  • runner/Cargo.toml
  • src/commands/mod.rs
  • src/commands/version.rs
🚧 Files skipped from review as they are similar to previous changes (2)
  • runner/Cargo.toml
  • src/commands/mod.rs

📝 Walkthrough

Walkthrough

This PR upgrades the pyo3 dependency from 0.28 to 0.29 across root and runner workspaces and refactors Python version detection from dynamic Python::attach callbacks to static Python::version_str() calls in telemetry and version modules.

Changes

pyo3 0.28 to 0.29 Upgrade

Layer / File(s) Summary
Dependency version updates
Cargo.toml, runner/Cargo.toml
pyo3 and pyo3-async-runtimes bumped from 0.28 to 0.29 in root and runner workspaces.
Python version string retrieval migration
src/commands/version.rs, src/commands/mod.rs
PYTHON_VERSION initialization and Sentry runtime context construction migrated from `Python::attach(

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A version bump hops with grace so light,
From 0.28 to 0.29's height,
Python strings now static, quick and clean,
No more callbacks in between,
Sentry logs the version true and right! 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: upgrading PyO3 from version 0.28 to 0.29 across multiple Cargo.toml files and related code.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch angel/upgrade_py03

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Cargo.toml`:
- Line 137: Replace the moving branch pin for the pyo3-async-runtimes dependency
with the exact commit SHA to ensure deterministic lockfiles: locate the
pyo3-async-runtimes dependency entry (the line with pyo3-async-runtimes and
branch = "angel/bump_pyo3_version") and change it to use rev =
"9c609defa70a2f9f7f3c407bff7696ba628e065d" instead of branch so Cargo.lock
refreshes remain stable.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 225c94db-c980-46e2-9660-bb47ec09bb45

📥 Commits

Reviewing files that changed from the base of the PR and between 8736106 and cf55583.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • Cargo.toml
  • runner/Cargo.toml
  • src/commands/mod.rs
  • src/commands/version.rs

Comment thread Cargo.toml Outdated
@cimandef cimandef force-pushed the angel/upgrade_py03 branch from cf55583 to a7044ae Compare June 15, 2026 09:07
@cimandef cimandef requested a review from jpopesculian June 15, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant