[WIP] Switched to use SQLAlchemy (with Alembic for DB migrations) instead of plain psycopg2#54
Closed
vporton wants to merge 14 commits into
Closed
[WIP] Switched to use SQLAlchemy (with Alembic for DB migrations) instead of plain psycopg2#54vporton wants to merge 14 commits into
vporton wants to merge 14 commits into
Conversation
apssouza22
requested changes
Oct 18, 2023
| @@ -1,48 +1,43 @@ | |||
| from typing import Dict | |||
| # TODO: Remove this file. | |||
Owner
There was a problem hiding this comment.
We will defintly not remove this file
| import psycopg2 | ||
|
|
||
|
|
||
| class DBConnection: |
Owner
There was a problem hiding this comment.
Alchemy can not appear anywhere else apart from this file. The whole applicaiton should not care about what DB client we are using.
I don't like using Alchemy in the applicatoin. It should be used only for DB migration.
I HATE ORM in general. It is a absolutly unnecessary complexity for any application.
I suggest you completly remove Alchemy. You only added unnecessary complexity to the project without any benefit
Contributor
Author
|
On request of @apssouza22 NOT to use an ORM, closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not tested at all!
This PR is based on PR #52.