Issue #18 - NPE with Array generator#19
Merged
Merged
Conversation
|
@djodjoni - Any idea when this fix can be merged? |
Malligarjunan
left a comment
Malligarjunan
left a comment
There was a problem hiding this comment.
Code changes looks Good. Could someone merge the changes?
Member
|
Hey @Malligarjunan ! Thank you for the input! I will make a new release in the next days ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@djodjoni
Hi,
First of all, thanks for this project. Its really useful for my project.
I have fixed the NPE when minItems, maxItems is not set in the json schema when the type is 'array'.
Detailed issue description: #17
I request you to do the code review and inform me if any changes are required.
Thanks,
Mohammed Rizwan