Always render ca.crt and sa.json in objstore secret to allow clearing on upgrade#1256
Merged
Conversation
… on upgrade Previously, ca.crt (s3) and sa.json (gcs) were conditionally omitted from the Secret template when their values were empty. This caused helm upgrade to leave stale values in the secret when the fields were removed from values.yaml. Now both fields are always rendered using `| default "" | quote`, ensuring that removing a value in values.yaml explicitly overwrites the secret key with an empty string on the next upgrade. Signed-off-by: Imtiaz Uddin <imtiaz@appscode.com>
Imtiaz246
changed the title
ArnobKumarSaha
previously approved these changes
May 20, 2026
Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, ca.crt (s3) and sa.json (gcs) were conditionally omitted from the Secret template when their values were empty. This caused helm upgrade to leave stale values in the secret when the fields were removed from values.yaml.
Now both fields are always rendered using
| default "" | quote, ensuring that removing a value in values.yaml explicitly overwrites the secret key with an empty string on the next upgrade.