Improve empty cert chain handling in TrustManagers#162
Open
aww-aww wants to merge 2 commits into
Open
Conversation
Updates the `checkClientTrusted` and `checkServerTrusted` methods in `CertificateTransparencyTrustManagerBasic` and `CertificateTransparencyTrustManagerExtended` to validate that the provided certificate chain and authType are not null or empty. This prevents a `NoSuchElementException` from being thrown when `chain.first()` is called on an empty chain, and ensures we instead throw an `IllegalArgumentException` as expected by the `X509TrustManager` contract. Tests were updated to provide an array containing a dummy X509Certificate mock instead of `emptyArray()` to prevent these validation checks from failing unintentionally during the delegation tests. Co-authored-by: aww-aww <2776327+aww-aww@users.noreply.github.com>
Fix empty cert chain handling in TrustManagers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the checkClientTrusted and checkServerTrusted methods in CertificateTransparencyTrustManagerBasic and CertificateTransparencyTrustManagerExtended to validate that the provided certificate chain and authType are not null or empty. Preventing a NoSuchElementException from being thrown when chain.first() is called on an empty chain, and ensuring we instead throw an IllegalArgumentException as expected by X509TrustManager.