[pull] master from SirPlease:master#135
Merged
Merged
Conversation
General: - Fixed players sometimes receiving strings in the wrong language. - Converted `Format` to `strcopy` for literal strings and `FormatEx` (where safe) for optimization sake. Boss Percent: - Replaced FakeClientCommand's `say` command on the client with a direct `sm_current`. - I'm leaving the Footer info in the language of the server, as the readyup menu doesn't build the menu content per client, may revisit in the future when modifying readyup. Match Vote: - The pop-ups will still render in the language of the server, initially I tried intercepting them through UserMessage but then I realized it's set on the netvars of g_Votecontroller, would require a lot of work for something minimal. Skill Detect: - Use translations inside the phrases file directly rather than use helper functions to hardcode them based on the current global translation target. - Not sure why we'd end up with 1 bhop streaks printing, but I'll leave it.
Sorta.
fix missing colon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )