Windows installation notes - #241
Merged
Merged
Conversation
mitchcapper
force-pushed
the
windows_cli_install_notes
branch
from
February 24, 2024 07:47
5d71902 to
05b3336
Compare
Closed
holzensp
requested changes
Apr 5, 2024
holzensp
left a comment
holzensp
left a comment
Collaborator
There was a problem hiding this comment.
I like it, but wanted to suggest some more compact wording. I think we should avoid spreading timeline promises through the technical documentation; that's bound to be overlooked in future.
Collaborator
There was a problem hiding this comment.
https://github.com/apple/pkl/issues/20[GitHub Issue #20] is used to track progress on support for the Windows platform.
Collaborator
|
@mitchcapper had you had a chance to take a look at the comments? |
mitchcapper
force-pushed
the
windows_cli_install_notes
branch
from
April 23, 2024 20:03
9fba2f4 to
f58ebf0
Compare
Contributor
Author
|
Sorry for the delay was trying to figure out where I had the checkout. Should be good to go. |
holzensp
approved these changes
Apr 24, 2024
holzensp
left a comment
holzensp
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks for the submission and the polish!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #237 notes about Windows platform support for the install docs. Assuming this is what was desired will add additional docs to --allowed-modules and update apple/pkl-jvm-examples#9 . apple/pkl-jvm-examples#9 is mostly not related to Windows, just likely Windows users may run into issues around its usage.
I am not sure what items other than allowed-modules may specifically have path related issues or if there is a better place to discuss Windows paths in more detail.
I have not found a way to sparse-checkout (cone or no-cone) or ignore the two invalid window path areas: