Skip to content

Fix ContainerResource build failure#1408

Merged
katiewasnothere merged 2 commits intoapple:mainfrom
DePasqualeOrg:fix-container-resource-collections-dependency
Apr 13, 2026
Merged

Fix ContainerResource build failure#1408
katiewasnothere merged 2 commits intoapple:mainfrom
DePasqualeOrg:fix-container-resource-collections-dependency

Conversation

@DePasqualeOrg
Copy link
Copy Markdown
Contributor

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

The ContainerResource target uses OrderedDictionary (added in #1360) but doesn't declare a dependency on swift-collections in Package.swift, and the source files import the Collections umbrella module instead of OrderedCollections. This causes build failures when OrderedDictionary is used in public declarations, since the compiler requires the specific submodule to be imported in that context.

  • Add swift-collections dependency to the ContainerResource target in Package.swift
  • Change import Collections to import OrderedCollections in ApplicationError.swift and ResourceLabels.swift

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

Copy link
Copy Markdown
Contributor

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank you!

@katiewasnothere katiewasnothere merged commit 2316905 into apple:main Apr 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants