ADFA-4857 | Add project-to-template plugin

[hal-eisen-adfa]

Summary

Incorporates the standalone templatize-project plugin into the monorepo as project-to-template/, conforming to repo conventions and wired into the build + website-deploy pipelines.

The plugin adds a Project to Template sidebar item that converts the currently-open Android project into a Code On The Go .cgt template bundle (original untouched — it copies then tokenizes with Pebble ${{TOKEN}}s) and can install it straight into the New Project template picker via IdeTemplateService.

What changed on the way in

• Full rename to org.appdevforall.projecttotemplate / "Project to Template".
• Shared infra: uses repo-root ../libs/*.jar and ../gradlew — no bundled jars or wrapper.
• Tooltip fix: getTooltipCategory() now returns the full plugin_org.appdevforall.projecttotemplate id, so the in-IDE tooltip renders real text instead of the literal n/a.
• Security: sanitizes the user-typed template name before using it as a filesystem path.
• Docs: Tier 3 offline help (assets/docs/index.html) + top-level website project-to-template-documentation.html.
• New icon: solid project card → arrow → dashed template card (day/night PNGs + monochrome ic_plugin vector), replacing the 4-square grid glyph. Source SVGs + generator under icon-src/.
• Text: normalized user-facing strings to "Code On The Go".
• Wiring: README Examples row + update-libs.yml website MAP entry.

Verification

• ../gradlew assemblePlugin and assemblePluginDebug both build clean.
• Passed the plugin-review rubric (green-light; 6.1 min-only IDE version is the repo norm).
• Device-verified on emulator end-to-end: installs, activates (survives restart), sidebar + 3-tier tooltip render (no n/a), and a real conversion of an open project (15 modified) produces a .cgt that installs via IdeTemplateService ([OK] Installed template).

🤖 Generated with Claude Code

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

_{Tip: disable this comment in your organization's Code Review settings.}

[jatezzz]

Review

Reviewed against freshly-fetched origin/main. I did not build or device-test — taking the PR's "builds clean + emulator-verified end-to-end" at face value.

What's right

The repo conventions are all here, including the ones that usually get missed: tooltip category is the full "plugin_org.appdevforall.projecttotemplate" form (not a slug), TOOLTIP_TAG is a shared const wired to the NavigationItem, Tier 3 getTier3DocsAssetPath() + a real assets/docs/index.html (white bg / black text), repo-root ../libs/*.jar + ../gradlew with no bundled copies, Theme.Material3.DayNight + values-night/, AAR metadata checks disabled, permission strings are exact enum values, sanitizeTemplateName genuinely kills traversal, views nulled in onDestroyView, dry run against a disposable temp copy, and both README + update-libs.yml MAP wiring are present.

Summary of findings

Should fix before merge:

1. Dark-mode status colors are hardcoded — the values-night variants are dead resources.
2. Re-running with a different template name zips the previous run into the new .cgt.
3. skipCleanup suppresses the personal-info warning too, including keystores.
4. local.properties ships in the .cgt by default.

Worth fixing (device-level cost):

5. The entire build/ tree is copied, then deleted.
6. Log rendering is O(n^2) on the main thread.

Minor: install button can't be retried after a failed install; the "unit-testable" KDoc claim is contradicted by android.util.Base64 + unitTests.isReturnDefaultValues = true; UI strings hardcoded rather than in strings.xml; duplicate log lines; isIgnoredUnderRoot is redundant with the onEnter prune; compileSdk/targetSdk = 34 will collide with #54.

Details are in the inline comments.

Verdict

Approve once #1 and #2 are fixed — those two produce visibly wrong output. #3/#4 are judgment calls, but both cut against the plugin's purpose (shipping a template someone else installs), so worth folding in here. Everything else is follow-up material.

[hal-eisen-adfa]

Thanks for the thorough review, @jatezzz — addressed everything in 2957e4e.

Should-fix

1. Dark-mode colors — showStatus now uses ContextCompat.getColor(…, R.color.status_error_text / status_success_text), so values-night/ is live.
2. Re-run bundling — a real run now wipes the whole outputDir (not just dest/) before copying, so a prior name's tree can't be zipped in. .cgt files live in outputDir.parentFile, so previous bundles are preserved.
3. skipCleanup suppressing warnings — flagPersonalInfoFiles now always runs; when cleanup is skipped, keystores are flagged ([REVIEW] … remove it before distributing) instead of silently shipped.
4. local.properties — added to COPY_IGNORE outright; google-services.json left flag-only as you suggested.

Worth-fixing
5. build/ — added to the copy-time skip when !skipCleanup, so it's never copied (was copy-then-delete).
6. O(n²) log — switched to logText.append("$line\n").

Minor

• Install button re-enables after a failed install (retry without re-converting).
• android.util.Base64 → java.util.Base64 (minSdk 26), and added JVM unit tests: sanitizeTemplateName (incl. traversal) + a dry-run substitution path. The dry-run pipeline touches no Android APIs, so it's safe under isReturnDefaultValues.
• UI strings moved to strings.xml.
• Removed the duplicate per-file [OK] lines (writePeb already logs) at the three sites.
• Deleted isIgnoredUnderRoot — the onEnter prune + name !in ignore filter cover it.

Note (12) — left compileSdk/targetSdk = 34 as-is. #54 (SDK 36) is still open and owns the toolchain bump; whichever lands second rebases, as you noted.

Verification — testDebugUnitTest + assemblePlugin green. Beyond the unit tests I ran the real (non-dry) createTemplateBundle twice via a JVM harness (Foo then Bar) and asserted the resulting .cgt contains no stale Foo/ subtree, no local.properties, no build/, and no .jks by default — and that skipCleanup retains and flags the keystore. All passed.

[hal-eisen-adfa]

Device verification (emulator, Code On The Go)

Installed the debug .cgp via IDE preferences → Plugin Manager (uninstalled the prior build, installed the new one, restarted) and drove the full flow against a real "My Application" project that contains a release.keystore, release.properties, and a build/ dir.

• feat/ADFA-3603 ndk plugin #2 (re-run isolation) — Converted as Alpha, then as Beta. Beta_Template.cgt (pulled + unzip) contains only Beta_Template/ + templates.json — no stale Alpha_Template/ subtree. The log's first line on the second run is [REMOVED] …/My Application-cgt (the new output-dir wipe). Both Alpha_Template.cgt and Beta_Template.cgt are preserved (the wipe only touches the intermediate bundle dir).
• (fix) Keyboard blocking the UI when typing in keystore generator #5 (build/) + Add tooltip to apk analyzer plugin #3 (keystore) default run — Alpha/Beta .cgt contain no build/, no release.keystore, no .gradle/.cg/.idea, even though the source project still has them. Summary: "removed 1" (the keystore).
• Add tooltip to apk analyzer plugin #3 (skip cleanup) — With "Skip build/ and keystore cleanup" checked (Gamma), the .cgt retains release.keystore and build/, and the log shows the new flag line: [REVIEW] …/release.keystore is a signing keystore; remove it before distributing this template (summary "1 to review"). Old code shipped it silently.
• chore: bump plugins to Kotlin 2.3.0 and migrate to compilerOptions DSL #1 (dark-mode colors) — Toggled the device to dark mode and re-ran. The success status renders as the values-night mint green (#8CD9B0), clearly readable on the dark surface — not the old hardcoded #0D6B42.
• Automate deployment of plugin cgp files to the ADFA website #7 (install) — "Install Template" registered via IdeTemplateService ([OK] Installed template: …); button stays disabled after a successful install (the if (!installed) re-enable is the retry-on-failure path).
• Add icon support to apkviewer plugin menu item #8/Adfa 4011 fix #10 — template/thumb.png decodes fine (java.util.Base64), and each processed file logs exactly one [OK] line (no duplicates).

.cgt contents confirmed by pulling each bundle off the device and inspecting with unzip.