fix: Remove isAtLeastJava9 check - #2
Closed
Wadamzmail wants to merge 3 commits into
Closed
Conversation
it useless on Android if we already embedded jrt-fs on the Application and breaks Kotlin LSP initialization on Android 10 and less devices so always use Application class loader
Contributor
Author
|
@itsaky-adfa Could you please review this PR? |
itsaky-adfa
requested changes
Jul 26, 2026
itsaky-adfa
left a comment
itsaky-adfa
left a comment
Collaborator
There was a problem hiding this comment.
@Wadamzmail Thank you for taking the time to create this PR. There are some minor changes needed before we can merge this.
Collaborator
|
@Wadamzmail Please merge the latest |
Contributor
Author
|
@itsaky-adfa review |
itsaky-adfa
approved these changes
Jul 31, 2026
Collaborator
|
Hey @Wadamzmail, Thank you for your contribution! I've merged the changes manually via commit 4d3c8ea (with some minor changes). Closing this PR. |
itsaky-adfa
added a commit
to appdevforall/CodeOnTheGo
that referenced
this pull request
Jul 31, 2026
See appdevforall/kotlin-android#2 Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The java version check is useless on Android if we already embedded jrt-fs on the Application and breaks Kotlin LSP initialization on Android 10 and less devices so always use Application class loader
see #1334