Use shared EllipsisAnimator in LibraryActivity; add fixed-width mode - #300
Merged
Conversation
added 2 commits
July 30, 2026 17:44
Replace the two inline dot-cycling animations in LibraryActivity (startBootEllipsis / startReadingEllipsis + the stop/handler/runnable fields) with the shared org.iiab.controller.util.EllipsisAnimator (ADFA-4842), which SetupProgressActivity already uses. Expand EllipsisAnimator with a fixed-width mode (space-padded, constant-width, monospaced suffix) so a centered line does not shift as the dots grow. Default stays variable-width plain text. Behavior note: the boot and extract-detail lines now render dots via the same helper; the extract line no longer inserts a space before the dots (unified with the boot line). No timing change (450 ms cadence).
Add onDestroy to stop bootEllipsis/readingEllipsis so the self-reposting Handler Runnable can't outlive the Activity and leak it via the TextViews. Mirrors SetupProgressActivity, which already stops its animator on destroy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rides the app UX/polish umbrella ADFA-4947 (references it; not a child).
Replaces the two inline dot-cycling animations in LibraryActivity (startBootEllipsis / startReadingEllipsis, plus stopBootEllipsis and the ellipsisHandler / ellipsisRunnable / bootBaseText fields) with the shared org.iiab.controller.util.EllipsisAnimator (ADFA-4842), which SetupProgressActivity already uses.
EllipsisAnimator gains a fixed-width mode (constructor flag): space-padded, constant-width, monospaced suffix so a centered line doesn't shift as the dots grow. Default stays variable-width plain text — one helper covers both cases.
Behavior note: the extract-detail line no longer inserts a space before the dots (unified with the boot line); 450 ms cadence unchanged.
Verify on device: the boot gate ("Starting your library…") and the extract "reading…" line animate and stay centered/stable across the boot → install → reading transition.