ADFA-4933: dev-push-dashboard.sh — propagate deletions, deploy nginx vhost - #298
Merged
Merged
Conversation
…vhost The tar copy was additive, so files removed in the repo (retired socket handlers, web UI) lingered in /library/dashboard and broke the build once socket.io was dropped from deps. - Drop the pure-source subdirs (sockets/views/public/test) before copying so removed files don't linger; node_modules and the sqlite job storage at the dashboard root are preserved. - Force a clean dist/ rebuild so removed sources don't survive as stale .js. - Deploy dash-node-nginx.conf to /etc/nginx/conf.d (nginx doesn't read /library/dashboard), mirroring the bootstrap installer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tar copy was additive, so files removed in the repo (retired socket handlers,
web UI) lingered in /library/dashboard and broke the build once socket.io was
dropped from deps.
node_modules and the sqlite job storage at the dashboard root.
/library/dashboard), mirroring the bootstrap installer.