Skip to content

ADFA-4925: Fix 4 Indonesian translation errors - #1599

Merged
hal-eisen-adfa merged 1 commit into
stagefrom
ADFA-4925-fix-indonesian-translations
Jul 29, 2026
Merged

ADFA-4925: Fix 4 Indonesian translation errors#1599
hal-eisen-adfa merged 1 commit into
stagefrom
ADFA-4925-fix-indonesian-translations

Conversation

@hal-eisen-adfa

Copy link
Copy Markdown
Collaborator

Follow-up to the merged #1591. A round-trip QA review (Gemini + Google Cloud Translate) of the merged values-in-rID/strings.xml surfaced four values that back-translate to the wrong meaning. Placeholders and escapes were all clean, so these are content-only fixes.

key English was now why
btn_opt_in Opt-in Ikuti (Follow) Setuju It is a consent button (matches the zh/de renderings)
msg_undock_save_failed ...Undock cancelled. Pembatalan pelepasan telah dibatalkan (double-cancel) Pelepasan dibatalkan. Removes the "cancellation was cancelled" double negative
profiler_heap_metric_count Instances Contoh (Example) Instansi Correct sense of heap-profiler object instances
agent_hint_search_pattern Search pattern... Petunjuk pencarian (hint) Pola pencarian... It is the pattern to match, not a hint

Ticket: ADFA-4925 (https://appdevforall.atlassian.net/browse/ADFA-4925)

Round-trip QA of the merged #1591 strings surfaced four values in
values-in-rID that convey the wrong meaning. Placeholders/escapes were
clean; these are content-only corrections.

- btn_opt_in: "Ikuti" (Follow) -> "Setuju" (it is a consent button)
- msg_undock_save_failed: drop the double-cancel -> "Pelepasan dibatalkan."
- profiler_heap_metric_count: "Contoh" (Example) -> "Instansi"
- agent_hint_search_pattern: "Petunjuk pencarian" (hint) -> "Pola pencarian"

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3df52b4c-805e-4759-b2b8-b11c2e819000

📥 Commits

Reviewing files that changed from the base of the PR and between a3f17fc and ff01dff.

📒 Files selected for processing (1)
  • resources/src/main/res/values-in-rID/strings.xml

📝 Walkthrough
  • Corrected four Indonesian localization strings based on round-trip QA:
    • Updated opt-in label to “Setuju”.
    • Simplified undock-save failure message.
    • Corrected profiler heap metric label to “Instansi”.
    • Corrected search-pattern hint to “Pola pencarian”.
  • No placeholders, escapes, or resource keys changed.
  • Risk: content-only localization changes; low risk.

Walkthrough

Four existing Indonesian localization strings were reworded for search hints, opt-in actions, undock save failures, and profiler heap metrics. No resource keys were added or removed.

Changes

Indonesian localization

Layer / File(s) Summary
Update Indonesian string values
resources/src/main/res/values-in-rID/strings.xml
Revises four existing displayed strings covering search patterns, opt-in, undock save failures, and profiler heap metric counts.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: elissa-appdevforall, mcikadu-dev

Poem

A rabbit hops through translated text,
Four little phrases now look their best.
Search, opt in, undock, heap in line,
Indonesian words neatly align.
Wiggle ears—localization shines!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: four Indonesian translation fixes.
Description check ✅ Passed The description is directly related and accurately describes the four translation corrections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ADFA-4925-fix-indonesian-translations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hal-eisen-adfa

Copy link
Copy Markdown
Collaborator Author

FYI @mcikadu-dev

@hal-eisen-adfa
hal-eisen-adfa merged commit b865016 into stage Jul 29, 2026
4 checks passed
@hal-eisen-adfa
hal-eisen-adfa deleted the ADFA-4925-fix-indonesian-translations branch July 29, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant