Redesign the Trails sort, search, and filter controls - #31
Open
NicooleT wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #29
Validation
npm run lintnpm run typecheckgit diff --checkstim-issue-29-trail-controlsSort by NameplusOpen trail searchBefore and after evidence
Before: the closed search control could collapse to zero width after focus was lost; the filter action expanded to show “Filters”; sheets used left-aligned titles and close buttons; a trail total remained below the controls.
After: the circular search action reliably returns after blur, the filter action stays icon-only, both sheets have centered titles and dismiss by scrim or handle drag, and the result-total row is gone. Screenshots and a short motion recording were captured from the same iOS simulator, Trails route, portrait orientation, and seed data.