Skip to content

fix: make recording sheet adjustable with accessibility actions #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
janicduplessis wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: make recording sheet adjustable with accessibility actions #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/features/record/RecordSheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
import { useCallback, useState } from 'react';
import { ActivityIndicator, Pressable, StyleSheet, Text, TextInput, View } from 'react-native';
import {
type AccessibilityActionEvent,
ActivityIndicator,
Pressable,
StyleSheet,
Text,
TextInput,
View,
} from 'react-native';
import { Ionicons } from '@expo/vector-icons';
import { Gesture, GestureDetector } from 'react-native-gesture-handler';
import Animated, {
Expand Down Expand Up @@ -64,6 +72,16 @@ export function RecordSheet({

const syncExpanded = useCallback((next: boolean) => setExpanded(next), []);

const onAccessibilityAction = (event: AccessibilityActionEvent) => {
if (event.nativeEvent.actionName === 'increment') {
height.value = withSpring(EXPANDED_HEIGHT, SPRING);
setExpanded(true);
} else if (event.nativeEvent.actionName === 'decrement') {
height.value = withSpring(COLLAPSED_HEIGHT, SPRING);
setExpanded(false);
}
};

const pan = Gesture.Pan()
.onStart(() => {
startHeight.value = height.value;
Expand Down Expand Up @@ -104,6 +122,8 @@ export function RecordSheet({
style={styles.grabArea}
accessibilityRole="adjustable"
accessibilityLabel={expanded ? 'Collapse hike stats' : 'Expand hike stats'}
accessibilityActions={[{ name: 'increment' }, { name: 'decrement' }]}
onAccessibilityAction={onAccessibilityAction}
>
<View style={[styles.handle, { backgroundColor: colors.border }]} />
<View style={styles.statusRow}>
Expand Down