Skip to content

fix: include trail stats in accessibility labels #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
janicduplessis wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: include trail stats in accessibility labels #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions src/components/TrailCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,15 @@ export function TrailCard({ trail, distanceMeters }: TrailCardProps) {
const router = useRouter();
const units = useSettingsStore((s) => s.units);
const accent = difficultyColor(trail.difficulty, colors);
const distance = formatDistance(distanceMeters, units);
const ascent = formatElevation(trail.elevationGainM, units);
const duration = formatDuration(trail.estimatedMinutes * 60);

return (
<Pressable
onPress={() => router.push({ pathname: '/trail/[id]', params: { id: trail.id } })}
accessibilityRole="button"
accessibilityLabel={`${trail.name}, ${trail.region}, ${difficultyLabel(trail.difficulty)}, rated ${trail.rating.toFixed(1)} out of 5`}
accessibilityLabel={`${trail.name}, ${trail.region}, ${difficultyLabel(trail.difficulty)}, rated ${trail.rating.toFixed(1)} out of 5, ${distance}, ${ascent} of ascent, estimated duration ${duration}`}
style={({ pressed }) => [
styles.card,
{ backgroundColor: colors.surface, borderColor: colors.border, opacity: pressed ? 0.9 : 1 },
Expand All @@ -64,17 +67,9 @@ export function TrailCard({ trail, distanceMeters }: TrailCardProps) {
</Text>

<View style={styles.stats}>
<Stat icon="walk-outline" value={formatDistance(distanceMeters, units)} color={colors.textMuted} />
<Stat
icon="trending-up-outline"
value={formatElevation(trail.elevationGainM, units)}
color={colors.textMuted}
/>
<Stat
icon="time-outline"
value={formatDuration(trail.estimatedMinutes * 60)}
color={colors.textMuted}
/>
<Stat icon="walk-outline" value={distance} color={colors.textMuted} />
<Stat icon="trending-up-outline" value={ascent} color={colors.textMuted} />
<Stat icon="time-outline" value={duration} color={colors.textMuted} />
</View>

<View style={styles.footer}>
Expand Down