fix(locale): don't leave a partial GeoIP database behind on failed download - #318
Merged
Conversation
…wnload downloadMMDB() streamed straight into MMDB_FILE, so an interrupted download left an empty or truncated database in place. getGeolocation() only checks that the file exists, so every later run reused the corrupt file and failed until it was deleted by hand. Download into a temporary file, close the stream and rename it into place only once the download completed, removing the temporary file on failure. Closing before the rename also makes sure the last buffered chunks are flushed before the database is opened. Refs #301 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
t-tooling
barjin
marked this pull request as ready for review
July 27, 2026 12:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
downloadMMDB()streamed straight intoMMDB_FILE, so an interrupted download left an empty or truncated database in place, and sincegetGeolocation()only checks that the file exists every later run reused the corrupt file and failed until it was deleted by hand. The download now goes into a temporary file that is renamed into place only once it completed, and the temporary file is removed on failure. Closing the stream before the rename also ensures the last buffered chunks are flushed before the database is opened. Refs #301