chore: standardize JDK 17 toolchain - #34
Merged
Merged
Conversation
kjonescertinia
approved these changes
Jul 26, 2026
kjonescertinia
marked this pull request as ready for review
July 26, 2026 15:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
javac -source 8 -target 8withjavac --release 8-release 8to the JVM project only, leaving Scala.js compiler settings unchangedThis makes build and publishing consistent while enforcing Java 8 platform API and bytecode compatibility for JVM artifacts.
No changelog entry is included because this changes build/CI enforcement and not user-facing behavior.
Validation
Using JDK 17.0.20:
sbt buildSAMPLES=/Users/kevinjones/adt/apex-samples sbt testafter restarting the pre-existing sbt server so it inherited the environment; 6,314 JVM tests and 52 Scala.js tests passedThe pinned sample checkout remained clean and detached at v1.4.0.