chore(deps): bump puppeteer from 22.15.0 to 24.43.1 - #96
Merged
Conversation
kjonescertinia
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
puppeteerfrom 22.15.0 to 24.43.1.This deliberately stops at v24, which is the highest version compatible with this package as it stands. It is the landable subset of Dependabot #91, which attempts 22 → 25 and fails CI.
Why not v25
v25 is ESM-only, and
benchmarkeris published as CommonJS (no"type": "module",main: dist/src/index.js). Taking it would require a package-level ESM migration, tracked separately in #95.v25 additionally raises Puppeteer's minimum Node to 22, while this package declares
"node": ">20.0.0"— so it would also be an engines change.Why v23 and v24 are safe here
Reviewed against actual usage in this repo:
isIncognito,ignoreHttpsErrors,product, the old query-handler APIs) are not used — the code already usesbrowser.createBrowserContext().args,headless,slowMo,timeout) remain valid.page.url()usage.Changes
package.json—puppeteer22.15.0 → 24.43.1package-lock.json— refreshedsrc/shared/env.ts—PuppeteerNodeLaunchOptionsno longer exists under that name; replaced with the currentLaunchOptions, narrowed to a type-only import since it is used purely in type positionVerification
Run locally against the real dependency tree, with Puppeteer's browser download not skipped:
npm ci— passed; fetched Chrome and chrome-headless-shell 148.0.7778.97npm run build— passednpm test— passed, 258 tests, 19 pending; a browser was genuinely launched (launched Chrome/148.0.7778.97)npm run lint— passedRelated