Skip to content

chore(deps): bump puppeteer from 22.15.0 to 24.43.1 - #96

Merged
kjonescertinia merged 1 commit into
mainfrom
ao/adt-7-puppeteer-v24
Jul 26, 2026
Merged

chore(deps): bump puppeteer from 22.15.0 to 24.43.1#96
kjonescertinia merged 1 commit into
mainfrom
ao/adt-7-puppeteer-v24

Conversation

@nawforce

Copy link
Copy Markdown
Collaborator

Summary

Bumps puppeteer from 22.15.0 to 24.43.1.

This deliberately stops at v24, which is the highest version compatible with this package as it stands. It is the landable subset of Dependabot #91, which attempts 22 → 25 and fails CI.

Why not v25

v25 is ESM-only, and benchmarker is published as CommonJS (no "type": "module", main: dist/src/index.js). Taking it would require a package-level ESM migration, tracked separately in #95.

v25 additionally raises Puppeteer's minimum Node to 22, while this package declares "node": ">20.0.0" — so it would also be an engines change.

Why v23 and v24 are safe here

Reviewed against actual usage in this repo:

  • The APIs removed in v23 (isIncognito, ignoreHttpsErrors, product, the old query-handler APIs) are not used — the code already uses browser.createBrowserContext().
  • v24 removed deprecated launch/connect options, but the ones used here (args, headless, slowMo, timeout) remain valid.
  • v24's request/response URL-fragment change does not affect this repo's page.url() usage.

Changes

  • package.jsonpuppeteer 22.15.0 → 24.43.1
  • package-lock.json — refreshed
  • src/shared/env.tsPuppeteerNodeLaunchOptions no longer exists under that name; replaced with the current LaunchOptions, narrowed to a type-only import since it is used purely in type position

Verification

Run locally against the real dependency tree, with Puppeteer's browser download not skipped:

  • npm ci — passed; fetched Chrome and chrome-headless-shell 148.0.7778.97
  • npm run build — passed
  • npm test — passed, 258 tests, 19 pending; a browser was genuinely launched (launched Chrome/148.0.7778.97)
  • npm run lint — passed

Related

@kjonescertinia
kjonescertinia merged commit 1c91bf1 into main Jul 26, 2026
1 check passed
@kjonescertinia
kjonescertinia deleted the ao/adt-7-puppeteer-v24 branch July 26, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants