feat: add support for salvo web framework - #130
Open
darixsamani wants to merge 22 commits into
Open
Conversation
…r and method with_ broadcaster (with festures sse)
geofmureithi
requested changes
Jul 13, 2026
geofmureithi
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution
- Please pass the broadcaster via state as this allows other routes the possibility of using it
- Lots of unnecessary comments can be removed
- Remove any commented code.
- Add an entry to Changelog.md
| use std::time::Duration; | ||
| use tracing::info; | ||
| use tracing_subscriber::{EnvFilter, Layer, layer::SubscriberExt, util::SubscriberInitExt}; | ||
|
|
Member
There was a problem hiding this comment.
Remove those unnecessary AI generated comments
Member
There was a problem hiding this comment.
There still alot of comments in this file that seem unnecessary. The code should be enough
| use std::time::Duration; | ||
| use tracing::info; | ||
| use tracing_subscriber::{EnvFilter, Layer, layer::SubscriberExt, util::SubscriberInitExt}; | ||
|
|
Member
There was a problem hiding this comment.
There still alot of comments in this file that seem unnecessary. The code should be enough
Member
|
Author
|
I need to run |
Author
|
Hi @geofmureithi, I already run cargo update and regenerated cargo vet exemptions. Please check my Pull Request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, I just added salvo as a feature of apalis-board as a web framework. This pull request solves issue #86
Type of Change
Testing
cargo fmtandcargo clippyChecklist
Additional Notes
I have run the command
cargo check --package apalis-board-api --features salvoto check the features that I am working on, and I have no warnings.I have also run the command
cargo run --package salvo-exampleto check the features that I am proposing, and everything is working fine, even the dashboardI have also introduced the new field in
ApiBuilderand also a new method
with_broadcasterto receive the broadcasterVideo Demonstration
Screencast.from.2026-07-12.17-12-18.webm