[SPARK-58753] Add Cargo workspace skeleton, vendored protos, and genproto crate - #2
Closed
viirya wants to merge 1 commit into
Closed
[SPARK-58753] Add Cargo workspace skeleton, vendored protos, and genproto crate#2viirya wants to merge 1 commit into
viirya wants to merge 1 commit into
Conversation
…roto crate Introduces the Cargo workspace for the Spark Connect Gateway: the root Cargo.toml (with the full [workspace.package] and [workspace.dependencies] tables; members lists only crates/genproto for now), Cargo.lock, rust-toolchain.toml, the vendored spark.connect.* protos under proto/, and the scg-genproto crate that generates tonic bindings from them at build time. This is the first of a series of small, bottom-up PRs importing the gateway reference implementation. Subsequent PRs append one or more crates to the workspace members list, keeping main green under the full CI matrix (fmt / clippy --all-targets / build / test --workspace) at each step. The proto files are a read-only mirror of the corresponding files in apache/spark; genproto's build.rs compiles them via tonic-prost-build. Co-authored-by: Claude Code
HyukjinKwon
approved these changes
Aug 13, 2026
Member
Author
|
Thank you @HyukjinKwon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is the first of a series of small, bottom-up PRs importing the Spark
Connect Gateway reference implementation (tracked in the do-not-merge reference
PR #1). It introduces the Cargo workspace:
Cargo.tomlwith the full[workspace.package]and[workspace.dependencies]tables.memberslists onlycrates/genprotofornow; subsequent PRs append one or more crates.
Cargo.lock(tracked — this project ships a binary),rust-toolchain.toml.spark.connect.*protos underproto/spark/connect/— aread-only mirror of the corresponding files in
apache/spark.scg-genprotocrate, whosebuild.rsgenerates tonic bindings from theprotos at build time via
tonic-prost-build.Each PR in this series keeps
maingreen under the full CI matrix(fmt / clippy --all-targets / build / test --workspace).
Why are the changes needed?
Implements the reference gateway from the approved SPIP (SPARK-58455), imported
into the
apache/spark-connect-gatewaysubproject repo one reviewable piece ata time.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warnings,cargo build --workspace, andcargo test --workspaceall pass locally.Was this patch authored or co-authored using generative AI tooling?
Yes, co-authored with Claude Code.