fs: rename PSEUDOFS_SOFTLINKS to FS_LINKS - #3753
Open
Kaben123 wants to merge 2 commits into
Open
Conversation
The link support is no longer limited to the pseudo file system and now covers both soft (symbolic) links and hard links across the VFS. Update all references to the renamed configuration option PSEUDOFS_SOFTLINKS, which has been renamed to FS_LINKS in the NuttX kernel, so that nshlib, the interpreters, adb, tlpi and the test suites keep building. This must be merged together with the corresponding NuttX change that performs the actual kernel-side rename. Signed-off-by: zhengyu16 <zhengyu16@xiaomi.com>
github-actions
Bot
added
Size: S
Area: Interpreters
Area: Examples
Size: M
and removed
Size: S
labels
Kaben123
force-pushed
the
pse52-01-link-infra-apps
branch
from
August 25, 2026 09:05
6dd4983 to
7620d91
Compare
jerpelea
previously approved these changes
Aug 25, 2026
🔗 Cross-repo PR dependenciesThe read-only Build run reported the following dependent PR(s) and fetched head SHA(s): CI run: https://github.com/apache/nuttx-apps/actions/runs/32830024845 |
Because this PR modifies nsh_fscmds.c and wamr/Kconfig, CI runs
nxstyle and codespell over the whole files and rejects pre-existing
issues that are unrelated to the rename:
- nsh_fscmds.c: reindent misaligned switch/case blocks in cmd_dmesg,
cmd_losetup, cmd_losmart, cmd_lomtd, cmd_mkdir, cmd_mkfatfs and
cmd_mkrd to the standard NuttX layout.
- wamr/Kconfig: fix two spelling typos flagged by codespell
("expections" -> "exceptions", "Configuable" -> "Configurable").
Style/whitespace and spelling only; no functional change.
Signed-off-by: zhengyu16 <zhengyu16@xiaomi.com>
Kaben123
force-pushed
the
pse52-01-link-infra-apps
branch
from
August 25, 2026 13:37
cb9d9fb to
706f3c2
Compare
xiaoxiang781216
approved these changes
Aug 25, 2026
🔗 Cross-repo PR dependenciesThe read-only Build run reported the following dependent PR(s) and fetched head SHA(s): CI run: https://github.com/apache/nuttx-apps/actions/runs/32854445960 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update all nuttx-apps references to the kernel filesystem-link config
option, which is renamed from PSEUDOFS_SOFTLINKS to FS_LINKS in the
companion NuttX PR. The link support is no longer limited to the pseudo
filesystem and now covers both soft (symbolic) and hard links across the
VFS, so the more accurate name FS_LINKS is used.
Affected areas: nshlib (ln/readlink/ls), interpreters (luv, wamr), adb,
tlpi example, and the testsuites — 18 references across 9 files.
Impact
each repository's build would break because the config symbol only
exists under one name at a time.
Testing
Depends-On: apache/nuttx#19949