apps/bttester: Remove a leftover/broken implementation - #2281
Open
mkasenberg wants to merge 1 commit into
Open
Conversation
It seems that the ccc_handle was intended to store the handle of the most recently updated CCC descriptor, however the field was overwritten with the descriptor value instead, so the unsubscription was failing. Apart from that in the RAP profile test cases there are multiple subscriptions and unsubscriptions, so the storing and the checks would be an obstacle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that the ccc_handle was intended to store the handle of the most recently updated CCC descriptor, however the field was overwritten with the descriptor value instead, so the unsubscription was failing. Apart from that in the RAP profile test cases there are multiple subsequent subscriptions and unsubscriptions, so the storing and the checks would be an obstacle.