Skip to content

nimble/transport: Fix double free in ble_hci_emspi_rx_acl() #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
94xhn wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −6
Open

nimble/transport: Fix double free in ble_hci_emspi_rx_acl() #2265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions nimble/transport/emspi/src/ble_hci_emspi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,12 +479,13 @@ ble_hci_emspi_rx_acl(void)
OS_MBUF_PKTLEN(om) = BLE_HCI_DATA_HDR_SZ + len;
om->om_len = BLE_HCI_DATA_HDR_SZ + len;

rc = ble_transport_to_hs_acl(om);
if (rc != 0) {
goto err;
}

return 0;
/*
* Ownership of `om` is transferred to the host here, regardless of the
* return value (see the comment on ble_hs_rx_data() in
* nimble/host/src/ble_hs.c). On failure the host has already freed it,
* so it must not be freed again via the `err` path below.
*/
return ble_transport_to_hs_acl(om);

err:
os_mbuf_free_chain(om);
Expand Down
Loading