nimble/host: Rework ble_gatts_notify_multiple_custom - #2229
Merged
Conversation
Contributor
Author
|
#AutoPTS run mynewt GATT/SR/GAN/BV-02-C |
|
Scheduled PR #2229 (comment), board: nrf52, estimated start time: 11:07:28, test case count: 1, estimated duration: 0:12:46 Test cases to be runGATT/SR/GAN/BV-02-C |
|
AutoPTS Bot results: Failed tests (1)GATT GATT/SR/GAN/BV-02-C RUNNING |
KKopyscinski
approved these changes
May 15, 2026
| goto err; | ||
| } | ||
|
|
||
| if ((supported & 0x04) == 0) { |
Contributor
There was a problem hiding this comment.
maybe supported features bit offsets should be globally available, to get rid of magic numbers
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
lets add those in ble_svc_gatt.h (after fixing masks value), also I don't think _NONE and _ALL are required
Simplify ble_gatts_notify_multiple_custom implementation: - reject if peer doesn't support it (app shall check it) - fail if doesn't git in single ATT packet - fix missing cleanups on error - fix missing endianess convertions ble_gatts_notify_multiple() is now very thin wrapper on top of ble_gatts_notify_multiple_custom().
piotrnarajowski
approved these changes
Jul 16, 2026
piotrnarajowski
left a comment
piotrnarajowski
left a comment
Contributor
There was a problem hiding this comment.
Tested this with #2269 by running GATT/SR/GAN/BV-02-C qualification test case. Also tried to issue a multiple handle value ntf with 12 HLV which exceeded mtu and properly triggered early exit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify ble_gatts_notify_multiple_custom implementation:
ble_gatts_notify_multiple() is now very thin wrapper on top of ble_gatts_notify_multiple_custom().