fix: make DependencyInfo.hashCode() consistent with equals() - #626
Open
elharo wants to merge 1 commit into
Open
Conversation
equals() compares only the 'dependency' field, but hashCode() incorrectly incorporated both 'dependency' and 'targetFileName', violating the equals/hashCode contract. Now hashCode() uses only 'dependency', matching equals(). Fixes apache#620
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the equals()/hashCode() contract for DependencyInfo by aligning hashCode() with the existing equals() semantics (dependency-only), and adds a dedicated unit test to prevent regressions.
Changes:
- Update
DependencyInfo.hashCode()to compute the hash fromdependencyonly (matchingequals()). - Add
DependencyInfoTestcovering dependency-only equality and hashCode consistency.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/org/apache/maven/plugins/war/util/DependencyInfo.java | Makes hashCode() consistent with equals() by hashing only dependency. |
| src/test/java/org/apache/maven/plugins/war/util/DependencyInfoTest.java | Adds regression tests for dependency-only equality and hashCode consistency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #620
equals()compares only thedependencyfield, buthashCode()incorrectly incorporated bothdependencyandtargetFileName, violating the equals/hashCode contract.Includes TDD: wrote failing test for hashCode consistency first, then applied the fix.